Closed
Conversation
This was referenced Mar 2, 2026
Merged
Member
|
There are a few things I think might make sense, but can leave that for after merging:
If you agree that none of those has to happen now, I'd merge #23 and open a tracking issue with the above for potential later enhancements. |
Collaborator
Author
|
Sure! I would prefer to merge #23 the way it is right now and add this as future issues, (can be assigned to me) I agree with all points, just didn't fully get "Check whether we always have to reinit the HASH if we always leave it in a good state". You mean checking the registers before writing on them? |
This was referenced Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR impl the embedded_cal::plumbing::hash::Sha2Short trait (only the SHA2-256) for the STM32 (tested on WBA55CG).